Re: [GIT PULL] Hole puch vs page cache filling races fixes for 5.14-rc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 30, 2021 at 10:25 AM Jan Kara <jack@xxxxxxx> wrote:
>
>   could you please pull from

No.

There is no way I'll merge something this broken.

Looking up a page in the page cache is just about the most critical
thing there is, and this introduces a completely pointless lock for
that situation.

Does it take the lock only when it creates the page? No. It takes the
lock in filemap_fault() even if it found a valid page in the page
cache.

This is just wrong.

               Linus



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux