On Thu, Jun 24, 2021 at 06:37:47PM +0100, Matthew Wilcox wrote: > On Wed, Jun 23, 2021 at 10:21:26AM +0200, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > > > Although I wish we could come up with a shorter name for > > mem_cgroup_track_foreign_dirty_slowpath somehow.. > > It is quite grotesque! > > How about folio_track_foreign_writeback() as a replacement name for > mem_cgroup_track_foreign_dirty() and have it call > __folio_track_foreign_writeback()? > > Although 'foreign' tends to be used in MM to mean "wrong NUMA node", > so maybe that's misleading. folio_track_dirty_cgroup()? > folio_mark_dirty_cgroup()? (the last to be read in context of > __set_page_dirty() being renamed to __folio_mark_dirty()) That all sounds reasonable to me, hopefully someone more attached to this code can pick one.
