Fair enough... I promise it is my generally my habit to do this and pay attention to the output before I send stuff to you: 1011 rm fs/orangefs/*.o 1012 make >>so clearly this has gotten absolutely zero testing. I wouldn't do you that way :-) ... I ran this through xfstests and left it on linux-next for a cycle. -Mike On Sat, Jun 26, 2021 at 1:02 PM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@xxxxxxxxxxxx> wrote: > > > > If it is not too late for these... the readahead adjustment > > was suggested by Matthew Wilcox and looks like how I should > > have written it in the first place... > > It wasn't too late - I pulled these. > > And then I un-pulled them. You removed all the uses of "file", but > left the variable, so it all warns about > > fs/orangefs/inode.c: In function ‘orangefs_readahead’: > fs/orangefs/inode.c:252:22: warning: unused variable ‘file’ > [-Wunused-variable] > 252 | struct file *file = rac->file; > | ^~~~ > > so clearly this has gotten absolutely zero testing. > > Linus
