Hi Petr > -----Original Message----- > From: Petr Mladek <pmladek@xxxxxxxx> > Sent: Thursday, June 24, 2021 4:47 PM > To: Justin He <Justin.He@xxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Steven Rostedt > <rostedt@xxxxxxxxxxx>; Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>; > Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>; Jonathan Corbet > <corbet@xxxxxxx>; Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>; Linus Torvalds > <torvalds@xxxxxxxxxxxxxxxxxxxx>; Peter Zijlstra (Intel) > <peterz@xxxxxxxxxxxxx>; Eric Biggers <ebiggers@xxxxxxxxxx>; Ahmed S. > Darwish <a.darwish@xxxxxxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; Matthew Wilcox > <willy@xxxxxxxxxxxxx>; Christoph Hellwig <hch@xxxxxxxxxxxxx>; nd > <nd@xxxxxxx> > Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path > of file > > On Wed 2021-06-23 03:14:33, Justin He wrote: > > Hi Andy > > > > > -----Original Message----- > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > Sent: Tuesday, June 22, 2021 10:40 PM > > > To: Justin He <Justin.He@xxxxxxx> > > > Cc: Petr Mladek <pmladek@xxxxxxxx>; Steven Rostedt > <rostedt@xxxxxxxxxxx>; > > > Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>; Rasmus Villemoes > > > <linux@xxxxxxxxxxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Alexander > > > Viro <viro@xxxxxxxxxxxxxxxxxx>; Linus Torvalds <torvalds@linux- > > > foundation.org>; Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>; Eric > > > Biggers <ebiggers@xxxxxxxxxx>; Ahmed S. Darwish > <a.darwish@xxxxxxxxxxxxx>; > > > linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > > > fsdevel@xxxxxxxxxxxxxxx; Matthew Wilcox <willy@xxxxxxxxxxxxx>; > Christoph > > > Hellwig <hch@xxxxxxxxxxxxx>; nd <nd@xxxxxxx> > > > Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full > path > > > of file > > > > > > On Tue, Jun 22, 2021 at 10:06:32PM +0800, Jia He wrote: > > > > Previously, the specifier '%pD' is for printing dentry name of struct > > > > file. It may not be perfect (by default it only prints one component.) > > > > > > > > As suggested by Linus [1]: > > > > > > Citing is better looked when you shift right it by two white spaces. > > > > Okay, I plan to cite it with "> " > > My understanding is that Andy suggested to omit '>' and prefix it by > plain two spaces " ". It would look better to me as well. Okay, got it -- Cheers, Justin (Jia He)
