On 22/06/2021 16.06, Jia He wrote: > After the behaviour of specifier '%pD' is changed to print the full path > of struct file, the related test cases are also updated. > > Given the full path string of '%pD' is prepended from the end of the scratch > buffer, the check of "wrote beyond the nul-terminator" should be skipped > for '%pD'. > > Parameterize the new using_scratch_space in __test, do_test to skip the > test case mentioned above, I actually prefer the first suggestion of just having a file-global bool. If and when we get other checks that need to be done selectively [e.g. "snprintf into a too short buffer produces a prefix of the full string", which also came up during this discussion but was ultimately kept] depending on the %<whatever> being exercised, we can add a "u32 nocheck" with a bunch of bits saying what to elide. Not insisting either way, just my $0.02. Rasmus
