On Mon, Jun 21, 2021 at 03:16:50PM +0100, Matthew Wilcox wrote: > On Mon, Jun 21, 2021 at 04:09:56PM +0200, Christoph Hellwig wrote: > > On Mon, Jun 21, 2021 at 03:03:07PM +0100, Matthew Wilcox wrote: > > > i suggested that to viro last night, and he pointed out that ioctl(S_SYNC) > > > > Where would that S_SYNC ioctl be implemented? > > xfs_diflags_to_iflags( > if (xflags & FS_XFLAG_SYNC) > flags |= S_SYNC; > > (mutatis mutandi per filesystem) Ok, your description above wasn't very exact. Anyway, that at least doesn't go out to the superblock. But if Al dislikes it we can also make generic_sync_file and friends check IS_SYNC() again. Having a single flag is kinda nice as it avoids stupid errors, but if we actually have a performance problem here (do we have any data on that?) just going back to the old way would seem like the simplest fix.
