On Wed, Jun 16, 2021 at 09:40:43AM -0700, Kees Cook wrote: > Information was redundant between struct pstore_zone_info and struct > pstore_device_info. Use struct pstore_zone_info, with member name "zone". > > Additionally untangle the logic for the "best effort" block device > instance. I'd still prefer to kill off struct pstore_device_info, but this is already a huge improvement: Reviewed-by: Christoph Hellwig <hch@xxxxxx>