Re: [PATCH] afs: fix no return statement in function returning non-void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tom Rix <trix@xxxxxxxxxx>
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 16 Jun 2021 14:41:35 +0100
Cc: dhowells@xxxxxxxxxx, Zheng Zengkai <zhengzengkai@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Hulk Robot <hulkci@xxxxxxxxxx>, linux-afs@xxxxxxxxxxxxxxxxxxx, Marc Dionne <marc.dionne@xxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Tom Rix <trix@xxxxxxxxxx> wrote:

> A fix is to use the __noreturn attribute on this function and not add a return
> like this
> 
> -static int afs_dir_set_page_dirty(struct page *page)
> +static int __noreturn afs_dir_set_page_dirty(struct page *page)
> 
> and to the set of ~300 similar functions in these files.

BUG() really ought to handle it.  Do you have CONFIG_BUG=y?

David

References:
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Tom Rix
- [PATCH] afs: fix no return statement in function returning non-void
  - From: David Howells
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Linus Torvalds
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Randy Dunlap
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Linus Torvalds
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Randy Dunlap
- Re: [PATCH] afs: fix no return statement in function returning non-void
  - From: Zheng Zengkai

Prev by Date: [PATCH] fs: Return raw xattr for security.* if there is size disagreement with LSMs
Next by Date: Re: Possible bogus "fuse: trying to steal weird page" warning related to PG_workingset.
Previous by thread: Re: [PATCH] afs: fix no return statement in function returning non-void
Next by thread: switch block layer polling to a bio based model v4
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]