Hi Gabriel, I love your patch! Yet something to improve: [auto build test ERROR on ext3/fsnotify] [also build test ERROR on linus/master v5.13-rc6 next-20210615] [cannot apply to ext4/dev] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210616-155248 base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify config: nios2-allnoconfig (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/53c00b0ce1aa2f3fd9e16a892cb44df278969b2d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210616-155248 git checkout 53c00b0ce1aa2f3fd9e16a892cb44df278969b2d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from fs/kernfs/file.c:16: include/linux/fsnotify.h: In function 'fsnotify_name': >> include/linux/fsnotify.h:33:2: error: implicit declaration of function '__fsnotify'; did you mean 'fsnotify'? [-Werror=implicit-function-declaration] 33 | __fsnotify(mask, &(struct fsnotify_event_info) { | ^~~~~~~~~~ | fsnotify fs/kernfs/file.c: In function 'kernfs_notify_workfn': >> fs/kernfs/file.c:887:7: error: passing argument 2 of 'fsnotify' from incompatible pointer type [-Werror=incompatible-pointer-types] 887 | inode, FSNOTIFY_EVENT_INODE, | ^~~~~ | | | struct inode * In file included from include/linux/fsnotify.h:15, from fs/kernfs/file.c:16: include/linux/fsnotify_backend.h:636:41: note: expected 'const struct fsnotify_event_info *' but argument is of type 'struct inode *' 636 | const struct fsnotify_event_info *event_info) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ >> fs/kernfs/file.c:886:5: error: too many arguments to function 'fsnotify' 886 | fsnotify(FS_MODIFY | FS_EVENT_ON_CHILD, | ^~~~~~~~ In file included from include/linux/fsnotify.h:15, from fs/kernfs/file.c:16: include/linux/fsnotify_backend.h:635:19: note: declared here 635 | static inline int fsnotify(__u32 mask, | ^~~~~~~~ cc1: some warnings being treated as errors vim +33 include/linux/fsnotify.h 19 20 /* 21 * Notify this @dir inode about a change in a child directory entry. 22 * The directory entry may have turned positive or negative or its inode may 23 * have changed (i.e. renamed over). 24 * 25 * Unlike fsnotify_parent(), the event will be reported regardless of the 26 * FS_EVENT_ON_CHILD mask on the parent inode and will not be reported if only 27 * the child is interested and not the parent. 28 */ 29 static inline void fsnotify_name(struct inode *dir, __u32 mask, 30 struct inode *child, 31 const struct qstr *name, u32 cookie) 32 { > 33 __fsnotify(mask, &(struct fsnotify_event_info) { 34 .data = child, .data_type = FSNOTIFY_EVENT_INODE, 35 .dir = dir, .name = name, .cookie = cookie, 36 }); 37 } 38 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
