Re: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ian Kent <raven@xxxxxxxxxx>
Subject: Re: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock
From: Miklos Szeredi <miklos@xxxxxxxxxx>
Date: Fri, 11 Jun 2021 15:14:17 +0200
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Fox Chen <foxhlchen@xxxxxxxxx>, Brice Goglin <brice.goglin@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Rick Lindsley <ricklind@xxxxxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Carlos Maiolino <cmaiolino@xxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com>

On Wed, 9 Jun 2021 at 10:52, Ian Kent <raven@xxxxxxxxxx> wrote:
>
> The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on
> any kernfs node so there's no reason to hold the kernfs node lock when
> calling it.
>
> Signed-off-by: Ian Kent <raven@xxxxxxxxxx>

Reviewed-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>

References:
- [PATCH v6 0/7] kernfs: proposed locking and concurrency improvement
  - From: Ian Kent
- [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock
  - From: Ian Kent

Prev by Date: Re: [PATCH v6 6/7] kernfs: add kernfs_need_inode_refresh()
Next by Date: Re: [PATCH v6 2/7] kernfs: add a revision to identify directory node changes
Previous by thread: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock
Next by thread: [LSF/MM/BPF TOPIC] durability vs performance for flash devices (especially embedded!)
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]