On Thu, Jun 10, 2021 at 12:18 PM Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
>
> I just didn't want those two lines hiding any other issues we might
> have in the coredumps.
>
> That is probably better development thinking than minimal fix thinking.
Well, I think we should first do the minimal targeted fix (the part in
fs/coredump.c).
Then we should look at whether we could do cleanups as a result of that fix.
And I suspect the cleanups might bigger than the two-liner removal.
The whole SIGNAL_GROUP_COREDUMP flag was introduced for this issue,
See commit 403bad72b67d ("coredump: only SIGKILL should interrupt the
coredumping task") which introduced this all.
Now, we have since grown other users of SIGNAL_GROUP_COREDUMP - OOM
hanmdling and the clear_child_tid thing in mm_release(). So maybe we
should keep SIGNAL_GROUP_COREDUMP around.
So maybe only those two lines end up being the ones to remove, but I'd
really like to think of it as a separate thing from the fix itself.
Linus
