On Mon, May 24, 2021 at 12:22:53PM +0800, Eryu Guan wrote: > Oh, I noticed that "with bcachefs fsck finding errors _always_ indicates > a bug" now.. Then I think using fsck -n is fine here, but better with > comments to describe why this is ok for bcachefs. > > Also, we could just use _check_scratch_fs here instead of the open-coded > fsck command. As _check_scratch_fs calls _check_generic_filesystem() > which calls fsck -n internally, and handles mount/umount device > correctly and prints pretty log if there's any errors. That should work.