On Tue, May 11, 2021 at 08:40:56AM -0700, Darrick J. Wong wrote: > > -static int vfs_dedupe_file_range_compare(struct inode *src, loff_t srcoff, > > - struct inode *dest, loff_t destoff, > > +static int vfs_dedupe_file_range_compare(struct file *src, loff_t srcoff, > > + struct file *dst, loff_t destoff, > > I kinda wish you'd maintained the name pairing here. Why does destoff > go with dst instead of dst/dstoff or dest/destoff? > > FWIW I try to vary the name lengths for similar variables these days, > because while my eyes are /fairly/ quick to distingiush 's' and 'd', > they're even faster if the width of the entire word is different. > > (And yes, I had to break myself of the 'columns-must-line-up' habit.) > > Using this method I've caught a few stupid variable name mixups in the > exchange-range code by doing a quick scan while ld takes an eternity to > link vmlinux together. OK, if that's a preference you have, I'll redo it. I have a later patch as part of the folio work which rename destfoo to dstfoo, but now I know that's a preference you have, I'll go back to dest. > That aside, passing file pointers in seems like a good idea to me. Cheers. v2 coming up.
