On Mon, May 10, 2021 at 03:27:56PM -0700, Darrick J. Wong wrote: > On Mon, May 10, 2021 at 09:12:01PM +0100, Matthew Wilcox (Oracle) wrote: > > A readahead request will not allocate more memory than can be represented > > by a size_t, even on systems that have HIGHMEM available. Change the > > length functions from returning an loff_t to a size_t. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > > Looks reasonable to me; is this a 5.13 bugfix or just something that > doesn't look right (i.e. save it for 5.14)? > > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Thanks! Linus was unhappy about it, and I promised to fix it. I leave it up to Andrew whether he wants to see this in 5.13 or 5.14. https://lore.kernel.org/linux-btrfs/CAHk-=wj1KRvb=hie1VUTGo1D_ckD+Suo0-M2Nh5Kek1Wu=2Ppw@xxxxxxxxxxxxxx/ (I went a little beyond what he was directly unhappy with and reviewed all the readahead.*length users for unnecessary loff_t usage)
