Mark Fasheh wrote: > On Mon, Dec 15, 2008 at 01:34:24PM +0530, Ankit Jain wrote: >> This patch adds ioctls to vfs for compatibility with legacy XFS >> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation >> effectively invokes sys_fallocate for the new ioctls. >> Note: These legacy ioctls are also implemented by OCFS2. >> >> There are some things that I'm not sure about: >> 1. Should the struct space_resv be exposed to user-space? If not, >> then what would be the right place to put it? And the ioctl >> definitions? > > Yes. As far as where to put it, I'm not sure. Maybe falloc.h? I'd sort of rather not; why should that legacy struct space_resv be available in a header... I thought this was for people already using the xfs ioctl, in which case they are already using the xfs header... and if they want preallocation in any new work, they should use fallocate() instead, yes? I mean it wouldn't hurt anything but it sort of confuses the interface story IMHO. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
