Hi David, On Fri, Apr 23, 2021 at 3:31 PM David Howells <dhowells@xxxxxxxxxx> wrote: > Make a netfs helper module to manage read request segmentation, caching > support and transparent huge page support on behalf of a network > filesystem. > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> Thanks for your patch, which is now commit 3ca236440126f75c ("mm: Implement readahead_control pageset expansion") upstream. > --- /dev/null > +++ b/fs/netfs/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config NETFS_SUPPORT > + tristate "Support for network filesystem high-level I/O" > + help > + This option enables support for network filesystems, including > + helpers for high-level buffered I/O, abstracting out read > + segmentation, local caching and transparent huge page support. TBH, this help text didn't give me any clue on whether I want to enable this config option or not. Do I need it for e.g. NFS, which is a network filesystem? I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this is just a library of functions, to be selected by its users, then please make the symbol invisible. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds