On Wed, Apr 28, 2021 at 10:19:58PM +0200, Aurélien Aptel wrote: > bfields@xxxxxxxxxxxx (J. Bruce Fields) writes: > > On Thu, Apr 22, 2021 at 09:28:14AM +0900, Namjae Jeon wrote: > >> This is the patch series for cifsd(ksmbd) kernel server. > > > > Looks like this series probably isn't bisectable. E.g. while looking at > > the ACL code I noticed ksmbd_vfs_setxattr is defined in a later patch > > than it's first used in. > > The Kconfig and Makefile are added in the last patch so it should be ok. I'm not sure if doing that way is really any better than making it one big patch. I'd rather see multiple patches that were actually functional at each stage: e.g., start with a server that responds to some sort of rpc-level ping but does nothing else, then add basic file IO, etc. I don't know if that's practical. --b.
