Re: [PATCH 15/15] nvme-multipath: enable polled I/O

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 27, 2021 at 06:16:19PM +0200, Christoph Hellwig wrote:
> Set the poll queue flags to enable polling, given that the multipath
> node just dispatches the bios to a lower queue.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  drivers/nvme/host/multipath.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
> index 1d17b2387884..0fa38f648ae7 100644
> --- a/drivers/nvme/host/multipath.c
> +++ b/drivers/nvme/host/multipath.c
> @@ -443,6 +443,8 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head)
>  		goto out;
>  	blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
>  	blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
> +	blk_queue_flag_set(QUEUE_FLAG_POLL_CAPABLE, q);
> +	blk_queue_flag_set(QUEUE_FLAG_POLL, q);

After POLL_CAPABLE is enabled on nvme mpath, POLL can be disabled via
queue_poll_store(). However, blk_mq_freeze_queue() just blocks and drain bio
submission, then pending POLL bio can't be polled any more because
QUEUE_FLAG_POLL is checked in bio_poll().


Thanks,
Ming




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux