On 2021/4/22 23:47, Matthew Wilcox wrote:
So ... what's going on with f2fs? Does it need to distinguish between a page which has f2fs_set_page_private(page, 0) called on it, and a page which has had f2fs_clear_page_private() called on it?
Yes, its intention here is just using Pageprivate to indicate there is some reference counts related to a dirty page, so value in page.private is meaningless. I guess we can avoid f2fs_set_page_private(page, 0) usage, instead, try to use SetPagePrivate() and assign page.private with non-zero value at the time. Thanks,