On Thu, 11 Dec 2008 23:32:13 +0100 Nick Piggin <npiggin@xxxxxxx> wrote: > > > + /* nothing tagged */ > > > + spin_unlock_irq(&mapping->tree_lock); > > > + return 0; > > > > Can we please avoid the deeply-nested-return hand grenade? > > Hmm, we could > > goto out; > ... > out: > return ret; > > But is that less hand grenadie than the plain return? yep. I've seen many many locking errors and resource leaks caused by the multiple-return-statements mistake. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
