Hi Jan, I love your patch! Yet something to improve: [auto build test ERROR on ext4/dev] [also build test ERROR on xfs-linux/for-next linus/master v5.12-rc7 next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Fix-data-corruption-when-extending-DIO-write-races-with-buffered-read/20210412-182524 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev config: um-allmodconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/0d289243d061378ac42188ff5079287885575bb3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jan-Kara/ext4-Fix-data-corruption-when-extending-DIO-write-races-with-buffered-read/20210412-182524 git checkout 0d289243d061378ac42188ff5079287885575bb3 # save the attached .config to linux build tree make W=1 ARCH=um If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] fs/zonefs/super.c: In function 'zonefs_file_dio_append': fs/zonefs/super.c:732:2: error: too few arguments to function 'zonefs_file_write_dio_end_io' 732 | zonefs_file_write_dio_end_io(iocb, size, ret, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/zonefs/super.c:654:12: note: declared here 654 | static int zonefs_file_write_dio_end_io(struct kiocb *iocb, ssize_t size, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/zonefs/super.c: At top level: >> fs/zonefs/super.c:961:14: error: initialization of 'int (*)(struct kiocb *, ssize_t, ssize_t, int, unsigned int)' {aka 'int (*)(struct kiocb *, long int, long int, int, unsigned int)'} from incompatible pointer type 'int (*)(struct kiocb *, ssize_t, int, unsigned int)' {aka 'int (*)(struct kiocb *, long int, int, unsigned int)'} [-Werror=incompatible-pointer-types] 961 | .end_io = zonefs_file_read_dio_end_io, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/zonefs/super.c:961:14: note: (near initialization for 'zonefs_read_dio_ops.end_io') cc1: some warnings being treated as errors vim +961 fs/zonefs/super.c 8dcc1a9d90c10fa Damien Le Moal 2019-12-25 959 8dcc1a9d90c10fa Damien Le Moal 2019-12-25 960 static const struct iomap_dio_ops zonefs_read_dio_ops = { 8dcc1a9d90c10fa Damien Le Moal 2019-12-25 @961 .end_io = zonefs_file_read_dio_end_io, 8dcc1a9d90c10fa Damien Le Moal 2019-12-25 962 }; 8dcc1a9d90c10fa Damien Le Moal 2019-12-25 963 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
