On Fri, Apr 9, 2021 at 5:30 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Apr 09, 2021 at 04:22:58PM +0300, Amir Goldstein wrote:
>
> > But we are actually going in cycles around the solution that we all want,
> > but fear of rejection. It's time to try and solicit direct feedback from Al.
> >
> > Al,
> >
> > would you be ok with passing mnt arg to vfs_create() and friends,
> > so that we can pass that to fsnotify_create() (and friends) in order to
> > be able to report FAN_CREATE events to FAN_MARK_MOUNT listeners?
>
> I would very much prefer to avoid going that way.
OK, so I will go with the more "expressive" implementation that Jan suggested.
Callers that do NOT care about mount mark semantics will use the
wrapper:
vfs_create_notify(mnt, ...)
{
vfs_create(...
fsnotify_create(NULL,...
}
The two callers that do care about mount mark semantics (syscalls
and nfsd) will open code:
vfs_create(...
fsnotify_create(mnt,...
Hope that way works better for you.
Thanks,
Amir.
