On Wed, Mar 31, 2021 at 11:51 PM Omar Sandoval <osandov@xxxxxxxxxxx> wrote: > > + * > + * The recommended usage is something like the following: > + * > + * if (usize > PAGE_SIZE) > + * return -E2BIG; Maybe this should be more than a recommendation, and just be inside copy_struct_from_iter(), because otherwise the "check_zeroed_user()" call might be quite the timesink for somebody who does something stupid. But otherwise this new version (still) looks fine to me. Linus