On 3/30/21 10:47 AM, Tetsuo Handa wrote: > On 2021/03/22 4:20, Linus Torvalds wrote: >> On Sun, Mar 21, 2021 at 7:37 AM Tetsuo Handa >> <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote: >>> >>> syzbot is reporting NULL pointer dereference at reiserfs_security_init() >> >> Whee. Both of the mentioned commits go back over a decade. >> >> I guess I could just take this directly, but let's add Jeff Mahoney >> and Jan Kara to the participants in case they didn't see it on the >> fsdevel list. I think they might want to be kept in the loop. >> >> I'll forward the original in a separate email to them. >> >> Jeff/Jan - just let me know if I should just apply this as-is. >> Otherwise I'd expect it to (eventually) come in through Jan's random >> fs tree, which is how I think most of these things have come in .. >> > > Linus, please just apply this as-is. > > Jan says "your change makes sense" at https://lkml.kernel.org/m/20210322153142.GF31783@xxxxxxxxxxxxxx > and Jeff says "Tetsuo's patch is fine" at https://lkml.kernel.org/m/7d7a884a-5a94-5b0e-3cf5-82d12e1b0992@xxxxxxxx > and I'm waiting for Jan/Jeff's reply to "why you think that my patch is incomplete" at > https://lkml.kernel.org/m/fa9f373a-a878-6551-abf1-903865a9d21f@xxxxxxxxxxxxxxxxxxx . > Since Jan/Jeff seems to be busy, applying as-is will let syzkaller answer to my question. Hi Tetsuo - You're right. The other call site in reiserfs_xattr_set is fine because of the privroot check before it. The patch is fine as-is. Thanks, -Jeff -- Jeff Mahoney Director, SUSE Labs Data & Performance
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
