Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> writes: > On 30/03/21 2:50 am, Gabriel Krisman Bertazi wrote: >>> +DEFINE_STATIC_CALL(_unicode_strncmp, unicode_strncmp_default); >>> +EXPORT_STATIC_CALL(_unicode_strncmp); >>> -int unicode_strncmp(const struct unicode_map *um, >>> - const struct qstr *s1, const struct qstr *s2) >>> -{ >>> - const struct utf8data *data = utf8nfdi(um->version); >>> - struct utf8cursor cur1, cur2; >>> - int c1, c2; >>> +DEFINE_STATIC_CALL(_unicode_strncasecmp, unicode_strncasecmp_default); >>> +EXPORT_STATIC_CALL(_unicode_strncasecmp); >> Why are these here if the _default functions are defined in the header >> file? I think the definitions could be in this file. No? > > > Inline functions defined in header file are using these functions so > cannot define them here in .c file. That is not a problem. It is regular C code, you can just move the definition to the C code and add the declaration to the header file, and it will work fine. -- Gabriel Krisman Bertazi