David Howells wrote:
Phillip Lougher <phillip@xxxxxxxxxxxxxxxxxxx> wrote:
You define these in the filesystem c files themselves as #defines. UDF and
BTRFS place theirs in the enum fid_type definition itself (in
linux/exportfs.h). Is there any reason why you didn't do this?
I don't know that we want to stick loads of filesystem-specific stuff into a
general header file. I believe we used to do that for struct inode (IIRC
there used to be a large union with filesystem-specific members).
FYI yes we did, back in the 2.4.x days, not only for struct inode but
also for struct super-block.
Personally I don't care where things are put, just as long as there's
consensus.
I know. As far as I know, there's no restriction on them reusing types 1 and
2, just an advisory note where these collide with other export types. Perhaps
Al or Christoph would care to comment on this.
Also, I don't know that changing these types would necessarily be a good
idea. wireshark, for example, could multiplex the types by the length as the
standard types are lengths 2 and 4, and ISOFS types are 3 and 5.
Quite, except ocfs2 also uses type 1 with a length of 3 :-) (it uses
type 2 with a length of 6).
People on LKML often complain too few people review patches. I get the
feeling I wish I never bothered here.
Phillip
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
