On Sat, Mar 20, 2021 at 03:51:40PM -0700, Chris Goldsworthy wrote: > On 2021-03-20 12:54, Matthew Wilcox wrote: > > On Sat, Mar 20, 2021 at 10:20:09AM -0700, Minchan Kim wrote: > > > > > Tested-by: Oliver Sang <oliver.sang@xxxxxxxxx> > > > > > Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> > > > > > Signed-off-by: Chris Goldsworthy <cgoldswo@xxxxxxxxxxxxxx> > > > > > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> > > > > > > > > The signoff chain ordering might mean that Chris was the primary author, but > > > > there is no From:him. Please clarify? > > > > > > He tried first version but was diffrent implementation since I > > > changed a lot. That's why I added his SoB even though current > > > implementaion is much different. So, maybe I am primary author? > > Hey Minchan, let's have you as the primary author. > > > Maybe Chris is Reported-by: ? And don't forget Laura Abbott as original > > author of the patch Chris submitted. I think she should be Reported-by: > > as well, since there is no code from either of them in this version of > > the patch. > > Yes, let's have a Reported-by: from Laura. We can change my Signed-off-by to > Reported-by: as well. Thanks Matthew and Chris. I just wanted to give more credit(something like Co-authored-by if we have such kinds of tag) to Chris since I felt he had more than. :) Okay, let's have something like this. From: Minchan Kim <minchan@xxxxxxxxxx> .. Tested-by: Oliver Sang <oliver.sang@xxxxxxxxx> Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> Reported-by: Laura Abbott <lauraa@xxxxxxxxxxxxxx> Reported-by: Chris Goldsworthy <cgoldswo@xxxxxxxxxxxxxx> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> Andrew, if you want me resend the patch, let me know. Thank you.
