On Mon, Mar 22, 2021 at 12:38:24PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The fallthrough comment for an ignored cmpxchg() return value > produces a harmless warning with 'make W=1': > > fs/posix_acl.c: In function 'get_acl': > fs/posix_acl.c:127:36: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 127 | /* fall through */ ; > | ^ > > Rewrite it as gcc suggests as a step towards a clean W=1 build. > On most architectures, we could just drop the if() entirely, but > in some cases this causes a different warning. And you don't see the warning for the second unconditional cmpxchg(p, sentinel, ACL_NOT_CACHED); below? > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- In any case that should be fine, Reviewed-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
