Re: [PATCH v5 26/27] mm/filemap: Convert page wait queues to be folios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20210319]
[cannot apply to linux/master linus/master hnaz-linux-mm/master v5.12-rc3 v5.12-rc2 v5.12-rc1 v5.12-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Memory-Folios/20210320-134732
base:    f00397ee41c79b6155b9b44abd0055b2c0621349
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/93822cea6776a7c6c5b1341ed1c3fdbd1e5eeaab
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Memory-Folios/20210320-134732
        git checkout 93822cea6776a7c6c5b1341ed1c3fdbd1e5eeaab
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   mm/filemap.c:1400: warning: Function parameter or member 'folio' not described in 'add_folio_wait_queue'
>> mm/filemap.c:1400: warning: expecting prototype for add_page_wait_queue(). Prototype was for add_folio_wait_queue() instead


vim +1400 mm/filemap.c

9a1ea439b16b92 Hugh Dickins            2018-12-28  1391  
385e1ca5f21c46 David Howells           2009-04-03  1392  /**
385e1ca5f21c46 David Howells           2009-04-03  1393   * add_page_wait_queue - Add an arbitrary waiter to a page's wait queue
697f619fc87aa9 Randy Dunlap            2009-04-13  1394   * @page: Page defining the wait queue of interest
697f619fc87aa9 Randy Dunlap            2009-04-13  1395   * @waiter: Waiter to add to the queue
385e1ca5f21c46 David Howells           2009-04-03  1396   *
385e1ca5f21c46 David Howells           2009-04-03  1397   * Add an arbitrary @waiter to the wait queue for the nominated @page.
385e1ca5f21c46 David Howells           2009-04-03  1398   */
93822cea6776a7 Matthew Wilcox (Oracle  2021-03-20  1399) void add_folio_wait_queue(struct folio *folio, wait_queue_entry_t *waiter)
385e1ca5f21c46 David Howells           2009-04-03 @1400  {
93822cea6776a7 Matthew Wilcox (Oracle  2021-03-20  1401) 	wait_queue_head_t *q = folio_waitqueue(folio);
385e1ca5f21c46 David Howells           2009-04-03  1402  	unsigned long flags;
385e1ca5f21c46 David Howells           2009-04-03  1403  
385e1ca5f21c46 David Howells           2009-04-03  1404  	spin_lock_irqsave(&q->lock, flags);
9c3a815f471a84 Linus Torvalds          2017-08-28  1405  	__add_wait_queue_entry_tail(q, waiter);
93822cea6776a7 Matthew Wilcox (Oracle  2021-03-20  1406) 	SetFolioWaiters(folio);
385e1ca5f21c46 David Howells           2009-04-03  1407  	spin_unlock_irqrestore(&q->lock, flags);
385e1ca5f21c46 David Howells           2009-04-03  1408  }
93822cea6776a7 Matthew Wilcox (Oracle  2021-03-20  1409) EXPORT_SYMBOL_GPL(add_folio_wait_queue);
385e1ca5f21c46 David Howells           2009-04-03  1410  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux