On Wed, Mar 17, 2021 at 08:25:51PM +0100, Miklos Szeredi wrote: > On Wed, Mar 17, 2021 at 6:01 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > > > On Wed, Mar 17, 2021 at 04:43:35PM +0100, Miklos Szeredi wrote: > > > On Tue, Mar 16, 2021 at 5:02 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > > > > > > > If ACL changes, it is possible that file mode permission bits change. As of > > > > now fuse client relies on file server to make those changes. But it does > > > > not send enough information to server so that it can decide where SGID > > > > bit should be cleared or not. Server does not know if caller has CAP_FSETID > > > > or not. It also does not know what are caller's group memberships and if any > > > > of the groups match file owner group. > > > > > > Right. So what about performing the capability and group membership > > > check in the client and sending the result of this check to the > > > server? > > > > Hi Miklos, > > > > But that will still be non-atomic, right? I mean server probably will > > do setxattr first, then check if SGID was cleared or not, and if it > > has not been cleared, then it needs to set the mode. > > > > IOW, we still have two operations (setxattr followed by mode setting). > > > > I had thought about that option. But could not understand what does > > it buy us as opposed to guest sending a SETATTR. > > If the non-atomic SETXATTR + SETATTR is done in the client, then the > server has no chance of ever operating correctly. > > If the responsibility for clearing sgid is in the server, then it's up > to the server to decide how to best deal with this. That may be the > racy way, but at least it's not the only possibility. > > Not sure if virtiofsd can do this atomically or not. > setgid()/setgroups() require CAP_SETGID, but that's relative to the > user namespace of the daemon, so this might be possible to do, I > haven't put a lot of thought into this. I guess you are right. virtiofsd can do it atomically. If client says to clear SGID, then virtiofsd can do following. A. Query who is file owner group. B. setgid(non-file-owner-group) C. drop CAP_FSETID D. setxattr(system.posix_acl_access). If file owner group is not root, then we don't have to do any setgid at all. If file owner group is root, then we have to find a gid which is valid in mount namespace of virtiofsd and switch to it. I guess at virtiofsd start time we can look at /proc/$$/gid_map and store on non-root gid which is valid. Only race here will be if another client changes file owner group between A and D and sets to same non-file-onwer-group we changed to. In that case it will not be cleared. Hmm.., may be post setxattr we can do another stat() and make sure SGID got cleared. If not, do a chmod. IOW, if atomic approach races, fall back to non-atomic approach. Litle twisted but should probably work. Will try. Thanks Vivek
