Re: [PATCH 3/7] cifs: don't declare smb_vol info on the stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 30 Nov 2008 14:49:04 -0600
"Steve French" <smfrench@xxxxxxxxx> wrote:

> I have thought about this a few times, but always hesitated because I
> was hoping that eventually cifs mount option parsing could use new
> parsing functions (which would also shrink the "parse_mount_options"
> routine which we call during cifs mount), and would cause us to
> rewrite this.  IIRC nfs was changed a few years ago to use the new
> mount mechanism (match_table and tokens).
> 

I think we'll still have a smb_vol struct or something like it,
regardless of how we end up doing the parsing. The results of the
parsing have to be recorded somewhere. There's a similar struct for NFS
as well (nfs_parsed_mount_data). We definitely should switch to the
standard parser, but I don't think this patch will make much difference
in how that is implemented.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux