On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote:
> Looks good, just one super minor nit inline.
> > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info)
> >
> > BUG_ON(!fbdefio);
> > cancel_delayed_work_sync(&info->deferred_work);
> > -
> > - /* clear out the mapping that we setup */
> > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
> > - page = fb_deferred_io_page(info, i);
> > - page->mapping = NULL;
> > - }
> > -
> > mutex_destroy(&fbdefio->lock);
> > }
>
> We no longer need the definition of "int i" right before the BUG_ON().
Huh. Usually gcc warns about that. let me figure that out and post a v2.
