Re: [PATCH take2] do_mpage_readpage(): remove first_logical_block parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 26 Nov 2008 21:04:52 +0100 Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote:

> This patch makes this function more readable IMHO by getting rid of
> its parameter 'first_logical_block'.
> 
> This parameter was previously used to remember the original block
> number in the file (ie the page index) that 'map_bh' was pointing
> at first. Indeed this was needed since 'map_bh->page' was modified
> even if 'map_bh' maps the whole current page (IOW when get_block()
> is not used). This had the bad effect to make the state of 'map_bh'
> inconsistent too.

Unfortunately we have a conflict with the already-queued
do_mpage_readpage-dont-submit-lots-of-small-bios-on-boundary.patch:

fs/mpage.c: In function 'do_mpage_readpage':
fs/mpage.c:315: error: 'relative_block' undeclared (first use in this function)
fs/mpage.c:315: error: (Each undeclared identifier is reported only once
fs/mpage.c:315: error: for each function it appears in.)
fs/mpage.c:315: error: 'first_logical_block' undeclared (first use in this function)
fs/mpage.c:316: error: 'nblocks' undeclared (first use in this function)

http://userweb.kernel.org/~akpm/mmotm/broken-out/do_mpage_readpage-dont-submit-lots-of-small-bios-on-boundary.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux