On Tue, Mar 2, 2021 at 5:26 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > I still feel that it should probably be fixed in virtiofsd, given fuse client > > is expecting file server to take care of any change of mode (file > > permission bits). > > Havid said that, there is one disadvantage of relying on server to > do this. Now idmapped mount patches have been merged. If virtiofs > were to ever support idmapped mounts, this will become an issue. > Server does not know about idmapped mounts, and it does not have > information on how to shift inode gid to determine if SGID should > be cleared or not. > > So if we were to keep possible future support of idmapped mounts in mind, > then solving it in client makes more sense. (/me is afraid that there > might be other dependencies like this elsewhere). > > Miklos, WDYT. Hmm sounds like two different modes of operation. 1) shared, non-idmapped: need to take care of races, so do the sgid clearing in the server 2) non-shared, idmapped: can only do it in client The same applies to all the other FUSE_*_KILL* stuff, so I guess the decision about the mode just needs to be tied to a flag in some way. Not sure if an existing one could be used. Thanks, Miklos
