On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
> ---
> kernel/trace/blktrace.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 4871934b9717..feb823b917ec 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -311,6 +311,43 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
> return 0;
> }
>
> +static inline bool prio_log_check(struct blk_trace_ext *bt, u32 ioprio)
> +{
> + bool ret;
> +
> + switch (IOPRIO_PRIO_CLASS(ioprio)) {
> + case IOPRIO_CLASS_NONE:
> + ret = (bt->prio_mask & 0x01) ? true : false;
> + break;
> + case IOPRIO_CLASS_RT:
> + ret = (bt->prio_mask & 0x02) ? true : false;
> + break;
> + case IOPRIO_CLASS_BE:
> + ret = (bt->prio_mask & 0x04) ? true : false;
> + break;
> + case IOPRIO_CLASS_IDLE:
> + ret = (bt->prio_mask & 0x08) ? true : false;
> + break;
> + default:
> + /*XXX: print rate limit warn here */
> + ret = false;
> + }
> + return ret;
> +}
> +
> +static inline int act_log_check_ext(struct blk_trace_ext *bt, u64 what,
> + sector_t sector, pid_t pid)
> +{
> + if (((bt->act_mask << BLK_TC_SHIFT_EXT) & what) == 0)
> + return 1;
> + if (sector && (sector < bt->start_lba || sector > bt->end_lba))
> + return 1;
> + if (bt->pid && pid != bt->pid)
> + return 1;
> +
> + return 0;
> +}
> +
> /*
> * Data direction bit lookup
> */
>
Without the code using these helpers in the same patch, it is hard to see what
these are for...
--
Damien Le Moal
Western Digital Research
