On 2/24/21 9:50 AM, Matthew Wilcox wrote: > On Wed, Feb 24, 2021 at 09:44:53AM -0700, Jens Axboe wrote: >> +++ b/include/linux/fs.h >> @@ -2633,6 +2633,8 @@ static inline int filemap_fdatawait(struct address_space *mapping) >> >> extern bool filemap_range_has_page(struct address_space *, loff_t lstart, >> loff_t lend); >> +extern bool filemap_range_needs_writeback(struct address_space *, >> + loff_t lstart, loff_t lend); >> extern int filemap_write_and_wait_range(struct address_space *mapping, >> loff_t lstart, loff_t lend); >> extern int __filemap_fdatawrite_range(struct address_space *mapping, > > These prototypes should all be in pagemap.h, not fs.h. I can do > a followup patch if you don't want to do it as part of this set. > Also we're deprecating the use of 'extern' for prototypes. Agree on both of those, but that should probably be a separate patch for both of those. extern is just following the existing style, and fs.h is the existing location... > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Thanks! -- Jens Axboe
