On Mon, Feb 22, 2021 at 5:25 PM Michal Hocko <mhocko@xxxxxxxx> wrote: > > On Sat 20-02-21 12:20:36, Muchun Song wrote: > > On Fri, Feb 19, 2021 at 10:12 PM Michal Hocko <mhocko@xxxxxxxx> wrote: > [...] > > > What about hugetlb page poisoning on HW failure (resp. soft offlining)? > > > > If the HW poisoned hugetlb page failed to be dissolved, the page > > will go back to the free list with PG_HWPoison set. But the page > > will not be used, because we will check whether the page is HW > > poisoned when it is dequeued from the free list. If so, we will skip > > this page. > > Can this lead to an under provisioned pool then? Or is there a new > hugetlb allocated to replace the poisoned one? Actually, no page will be allocated. Your concern is right. But without this patch, the result does not change. e.g. The HW poisoned page can fail to be dissolved when h->free_huge_pages is equal to h->resv_huge_pages. But no one seems to have reported this issue so far. Maybe this behavior needs improvement in the feature. > > -- > Michal Hocko > SUSE Labs
