On Sun, 2008-11-23 at 06:57 -0500, Jeff Layton wrote: > On Sat, 22 Nov 2008 14:27:44 -0600 > Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxxxx> wrote: > > > Just took a real quick look, but I have one comment. I'd leave the page > > alone if it's already PageUptodate. I wouldn't bother setting > > PageChecked and let cifs_write_end leave it alone when its already > > uptodate. > > Ok, it makes sense not to flip page bits unless we need to. How's this > instead? It also switches the code to use zero_user_segments() instead > of calling kmap/memset directly. Acked-by: Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxxxx> > > I've dropped Steve's SoB for now since this has morphed quite a bit from > his original patch. Steve, feel free to add it back if you approve. -- David Kleikamp IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html