On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote: > Joe Perches <joe@xxxxxxxxxxx> writes: > > > Convert S_<FOO> permissions to the more readable octal. > > > > Done using: > > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS fs/proc/*.[ch] > > > > No difference in generated .o files allyesconfig x86-64 > > > > Link: > > https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@xxxxxxxxxxxxxx/ > > > I will be frank. I don't know what 0644 means. I can never remember > which bit is read, write or execute. So I like symbolic constants. > > I don't see a compelling reason to change the existing code. Did you read Linus' message in the Link: above? It was a reply to what Ingo Molnar suggested here: https://lore.kernel.org/lkml/20160803081140.GA7833@xxxxxxxxx/
