On Sat, 2008-11-22 at 20:27 +0100, Sebastian Andrzej Siewior wrote: > * Artem Bityutskiy | 2008-11-21 19:19:24 [+0200]: > > > save_flags = mst->flags; > >- mst->flags = cpu_to_le32(le32_to_cpu(mst->flags) | UBIFS_MST_RCVRY); > >+ mst->flags |= cpu_to_le32(UBIFS_MST_RCVRY); > > another micro optimisation would be to use __constant_cpu_to_le32() > Nope, no difference, cpu_to_le32 does constant-detection these days and so there ends up being no difference. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html