On Tue, Feb 9, 2021 at 11:14 AM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote: > > On Tue, Feb 9, 2021 at 9:47 AM Yang Shi <shy828301@xxxxxxxxx> wrote: > > > > The tracepoint's nid should show what node the shrink happens on, the start tracepoint > > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the > > shrinker is not NUMA aware, so the traceing > > tracing Fixed. Thanks. > > > log may show the shrink happens on one > > node but end up on the other node. It seems confusing. And the following patch > > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup > > the code. > > > > Acked-by: Vlastimil Babka <vbabka@xxxxxxx> > > Acked-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> > > Signed-off-by: Yang Shi <shy828301@xxxxxxxxx> > > Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
