On Tue, Feb 09, 2021 at 09:19:16AM +1100, Dave Chinner wrote: > Nope, not convinced at all. As a generic interface, it cannot be > designed explicitly for the needs of a single filesystem, especially > when there are other filesystems needing to implement similar > functionality. > > As Amir pointed up earlier in the thread, XFS already already has > extensive per-object verification and error reporting facilicities... Sure, but asking Collabora to design something which works for XFS and not for ext4 is also not fair. If we can't design something that makes XFS happy, maybe it will be better to design something specific for ext4. Alternatively, perhaps the only thing that can be made generic is to avoid scope creep, and just design something which allows telling userspace "something is wrong with the file system", and leaving it at that. But asking Collabora to design something for XFS, but doesn't work for ext4, is an absolute non-starter. > If we've already got largely standardised, efficient mechanisms for > doing all of this in a filesystem, then why would we want to throw > that all away when implementing a generic userspace notification > channel? You don't. And if you want to implement something that works perfectly for xfs, but doesn't work for ext4, feel free. Cheers, - Ted
