Re: [PATCH] cifs: use discard iterator to discard unneeded network data more efficiently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aurélien Aptel <aaptel@xxxxxxxx> wrote:

> > +{
> > +	struct msghdr smb_msg;
> > +
> > +	iov_iter_discard(&smb_msg.msg_iter, READ, to_read);
> > +
> > +	return cifs_readv_from_socket(server, &smb_msg);
> > +}
> > +
> 
> Shouldn't smb_msg be initialized to zeroes? Looking around this needs to
> be done for cifs_read_from_socket() and cifs_read_page_from_socket() too.

Yeah - I think you're right.  I didn't manage to finish making the changes,
so what I gave to Steve wasn't tested.

David





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux