On Mon, Feb 1, 2021 at 3:57 PM Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx> wrote: > > On 2/1/21 15:50, Amy Parker wrote: > > Especially in an expanded form like this, these are ugly to read, and > > a pain to work with. > > > > An example of potentially a better method, from fs/dax.c: > > > > #define DAX_SHIFT (4) > > #define DAX_LOCKED (1UL << 0) > > #define DAX_PMD (1UL << 1) > > #define DAX_ZERO_PAGE (1UL << 2) > > #define DAX_EMPTY (1UL << 3) > I think this is much better to read with proper alignment. Yep - on the actual file it is.
