On Thu, Nov 20, 2008 at 3:29 AM, Jörn Engel <joern@xxxxxxxxx> wrote:
> On Wed, 19 November 2008 18:26:00 -0800, Warren Turkal wrote:
>>
>> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
>> index eb74531..4f00a84 100644
>> --- a/fs/hfsplus/super.c
>> +++ b/fs/hfsplus/super.c
>> @@ -15,10 +15,17 @@
>> #include <linux/vfs.h>
>> #include <linux/nls.h>
>>
>> +#include "hfsplus_fs.h"
>> +
>> static struct inode *hfsplus_alloc_inode(struct super_block *sb);
>> static void hfsplus_destroy_inode(struct inode *inode);
>> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr);
>
> Sorry for not noticing this before. The function declaration is
> unnecessary. There are no callers before the actual function
> definition, which is just below.
I will have to get rid of this when I get home tonight.
>> -#include "hfsplus_fs.h"
>> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
>> +{
>> + return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
>> + vhdr->journal_info_block);
>> +}
>
> You're going through a huge number of iterations for such a simple
> change. Others would have lost patience some time ago. :(
Bah...I'm playing in someone else's sandbox, and I have a lot to learn
around here. I figure I probably shouldn't second guess the more
experienced folks.
wt
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
