On Thu, Jan 28, 2021 at 02:21:02PM +0300, Dan Carpenter wrote:
> Hello Christian Brauner,
>
> The patch 2f221d6f7b88: "attr: handle idmapped mounts" from Jan 21,
> 2021, leads to the following static checker warning:
>
> fs/attr.c:129 setattr_prepare()
> warn: inconsistent indenting
>
> fs/attr.c
> 124 /* Make sure a caller can chmod. */
> 125 if (ia_valid & ATTR_MODE) {
> 126 if (!inode_owner_or_capable(mnt_userns, inode))
> 127 return -EPERM;
> 128 /* Also check the setgid bit! */
> 129 if (!in_group_p((ia_valid & ATTR_GID) ? attr->ia_gid :
> ^^^^^^^^^^^^^^^^^
> The patch accidentally swapped tabs for spaces.
Thanks. Must've sneaked in despite clang-format. Will likely fix in a
separate commit. I don't want to rebase because of this.
