On Fri, Jan 22, 2021 at 02:55:30PM +0000, Mark Harmstone wrote: > On 22/1/21 2:01 pm, Konstantin Komarov wrote: > > diff --git a/fs/ntfs3/upcase.c b/fs/ntfs3/upcase.c > > +static inline u16 upcase_unicode_char(const u16 *upcase, u16 chr) > > +{ > > + if (chr < 'a') > > + return chr; > > + > > + if (chr <= 'z') > > + return chr - ('a' - 'A'); > > + > > + return upcase[chr]; > > +} > > Shouldn't upcase_unicode_char be using the NTFS pseudo-file $UpCase? > That way you should also be covered for other bicameral alphabets. return upcase[chr] is just for that? Upcase table from $UpCase is constucted in super.c and this will get it in and use it.