On 1/26/21 9:13 PM, Amy Parker wrote: > On Tue, Jan 26, 2021 at 7:59 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> >> On 1/26/21 7:46 PM, Randy Dunlap wrote: >>> Hi Amy, >>> >>> What mail client did you use? >>> It is breaking (splitting) long lines into shorter lines and that >>> makes it not possible to apply the patch cleanly. > > Was worried about that, thought I had all my settings straightened out. > >>> >>> You can see this problem below or on the web in an email archive. >>> >>> Possibly Documentation/process/email-clients.rst can help you. > > Yeah, read that. Thought I had everything fixed up. > >> >> Also tabs in the source file have been converted to spaces. > > Was this inconsistent throughout the patch? I can't really seem to > tell. If it's consistent, bet it's probably my mail client - if it's > inconsistent it could be my editor, I had to switch out temporarily > for a different editor today. > There are no tabs in the patch. >> >> It would be good if you could email a patch to yourself and then >> see if you can apply cleanly it to your source tree (after removing >> any conflicting patches, of course -- or use a different source >> tree). > > Yeah, I'll make sure to double check with that in the future. > >> >> >> -- >> ~Randy >> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> netiquette: https://people.kernel.org/tglx/notes-about-netiquette > > Should I send in a v2 of this patchset, or just attach the patch here? > If I should just attach it here, then I'll do the same for patch 2/2. An attachment might be OK once but it would be better if you could get inline patches to work. You'll need to do that... -- ~Randy
