Re: [PATCH 05/17] block: use an on-stack bio in blkdev_issue_flush

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>
Subject: Re: [PATCH 05/17] block: use an on-stack bio in blkdev_issue_flush
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
Date: Tue, 26 Jan 2021 19:15:02 +0000
Accept-language: en-US
Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Chao Yu <chao@xxxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Damien Le Moal <Damien.LeMoal@xxxxxxx>, Naohiro Aota <Naohiro.Aota@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, "linux-nilfs@xxxxxxxxxxxxxxx" <linux-nilfs@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx" <linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx" <drbd-dev@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>
Ironport-sdr: 9F2eAYyHkgpATgkwLy1uhYiWsWZ5LUuQnRgygSejEf4CRXwtTGSIB+/CXjZ+orLDwIb2vr4hz8 JWLrr9ZTteiUk4tXxaXO6ez5X4SQZqIRVo56fAxonHw4cBna5z1++vvKDZ8uaVB86eBC7ww5Mq 5zz2samSRkv59suuw3mqY6j/cwogoIKOScSh+7+WLbAhywqZKASd2+LuCqNCUIBrhh2xyqtigO nezlYVMAxxnHYeMq7i/fxkvk2fmTgcalMTqHvEnWauWTZN/pLxuCv+MzlAMzO5Nvu8fy8Vmg1X yHw=
Thread-index: AQHW8/UAfT2lRjWk50ewoG8V7AspXA==
Thread-topic: [PATCH 05/17] block: use an on-stack bio in blkdev_issue_flush
Wdcipoutbound: EOP-TRUE

On 1/26/21 7:07 AM, Christoph Hellwig wrote:
> There is no point in allocating memory for a synchronous flush.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

True, looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

References:
- misc bio allocation cleanups
  - From: Christoph Hellwig
- [PATCH 05/17] block: use an on-stack bio in blkdev_issue_flush
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 02/17] btrfs: use bio_kmalloc in __alloc_device
Next by Date: Re: [PATCH 16/17] nilfs2: remove cruft in nilfs_alloc_seg_bio
Previous by thread: [PATCH 05/17] block: use an on-stack bio in blkdev_issue_flush
Next by thread: [PATCH 06/17] dm-clone: use blkdev_issue_flush in commit_metadata
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]