On Mon, Jan 25, 2021 at 09:36:13PM +0000, David Howells wrote:
> +int nfs_readpage_async(void *data, struct inode *inode,
> struct page *page)
> {
> + struct nfs_readdesc *desc = (struct nfs_readdesc *)data;
You don't need a cast to cast from void.
> @@ -440,17 +439,16 @@ int nfs_readpages(struct file *filp, struct address_space *mapping,
> if (ret == 0)
> goto read_complete; /* all pages were read */
>
> - desc.pgio = &pgio;
> - nfs_pageio_init_read(&pgio, inode, false,
> + nfs_pageio_init_read(&desc.pgio, inode, false,
I like what you've done here, embedding the pgio in the desc.
